You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added calculations for mates’ maximum HP and MP based on race, level, and growth factor. Race-specific values are supported for races 0–6 and 8; flat HP and MP are not included.
Documentation
Added reference tables showing mate HP and MP values across selected races, levels, and growth factors.
A mate's maximum HP and MP follow its monster entry's race and growth
factors as it levels. Recorded pets at level 28 and 48 match the curve
exactly.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014gSmkVtYup7KTZ63CJcxZT
No actionable comments were generated in the recent review.
Walkthrough
The change adds mate HP and MP calculation services. It also adds a shared effective-level helper and approval-test coverage that checks selected results and generates tables for races 0–6 and 8.
Changes
Mate HP and MP calculations
Layer / File(s)
Summary
Mate HP and MP calculation services src/NosCore.Algorithm/MateHpService/*, src/NosCore.Algorithm/MateMpService/*, test/NosCore.Algorithm.Tests/DocumentationTest.cs, documentation/DocumentationTest.MateHpMpDocumentation.approved.md
Adds HP and MP service interfaces and implementations. The calculations use race-specific values and effective levels. The approval test checks selected results and generates tables for the listed races, factors, and levels.
This change adds new mate HP and MP calculation services with documentation tests. No concrete merge-blocking risk was found; the recorded examples reportedly match the curves.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "Add pet and partner HP and MP curves" matches the main change. The PR adds IMateHpService/MateHpService and IMateMpService/MateMpService, which calculate maximum HP and MP for pets and part…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "Add pet and partner HP and MP curves" matches the main change. The PR adds IMateHpService/MateHpService and IMateMpService/MateMpService, which calculate maximum HP and MP for pets and partners from race, level, and growth factors. The title is specific and concise, and it names the primary change without file lists or vague terms.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of NosCoreIO/NosCore#2826
Adds
IMateHpService/MateHpServiceandIMateMpService/MateMpService. They give a pet's or partner's maximum HP and MP from:The flat HP and MP from the entry's HP/MP line come on top.
Recorded pets match exactly:
The documentation test asserts both rows, and its approval table covers every race at factors 0, 4, 8 and 12. New feature, so this releases as 6.1.0.
Generated by Claude Code
Summary by CodeRabbit